Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a unique name for the cloud location of digests artifacts Cardano database #2314

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Use a unique name for the cloud location of digests artifacts Cardano database #2314

merged 3 commits into from
Feb 17, 2025

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Feb 14, 2025 •
edited
Loading

Content

Fix the naming of the Cloud storage digests location in the artifacts of the Incremental Cardano DB.
The new format name is: <NETWORK>-e<EPOCH>-i<IMMUTABLE_FILE_NUMBER>.digests.json
Example: mainnet-e5-i456.digests.json"

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2306

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 57s ⏱️ -2s
1 598 tests +1  1 598 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 902 runs  +1  1 902 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 19fa6c9. ± Comparison against base commit f6f3b2b.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-sanchonet February 14, 2025 11:10 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review February 14, 2025 13:58
jpraynaud
jpraynaud approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel
Use a unique name for the digest
d9c48f8
@sfauvel
Add cardano-database/digests folder to the cloud storage lifecycle …
a604819 
…rule in the infra
@sfauvel
chore: upgrade crate versions
19fa6c9 
* mithril-aggregator from `0.7.3` to `0.7.4`
* mithril-infra from `0.3.12` to `0.3.13`
@sfauvel sfauvel force-pushed the sfa/2306/fix_naming_of_the_cloud_storage_digests_location branch from 9ca6713 to 19fa6c9 Compare February 17, 2025 08:51
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 17, 2025 08:59 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit e7cdba1 into main Feb 17, 2025
38 of 41 checks passed
@sfauvel sfauvel deleted the sfa/2306/fix_naming_of_the_cloud_storage_digests_location branch February 17, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digests file for Incremental Cardano DB is not updated on the cloud location
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume